Repository navigation
Conversation
Sets isc_dpb_max_inline_blob_size and isc_dpb_max_blob_cache_size (Firebird 5.0.3+).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses item 2 of #74 (feedback).
Adds attachment options for the inline blob transfer introduced in Firebird 5.0.3. With inline blobs, small blobs come back with the rows of a result set instead of needing a round trip per blob, which matters a lot over remote connections.
Changes
AttachmentOptions::setMaxInlineBlobSize(std::uint32_t)/getMaxInlineBlobSize(): setsisc_dpb_max_inline_blob_size.AttachmentOptions::setMaxBlobCacheSize(std::uint32_t)/getMaxBlobCacheSize(): setsisc_dpb_max_blob_cache_size.Both work like the other optional DPB items in
Attachment's constructor. Older Firebird versions ignore them.Tests
AttachmentSuite/inlineBlobOptionsattaches with both options set and checks the values throughIAttachment::getMaxInlineBlobSize()andgetMaxBlobCacheSize().Full suite: 349 test cases pass (Windows, MSVC, Firebird 5.0.3 server).